Repository navigation
Continual Harness and Harness² declare the adapter parts they write - #123
Merged
Merged
Conversation
Both methods write skills and sub-agents (Harness² hooks too), but their evolver.yaml declared `needs: [llm]` and `needs: []`, so a run with an acting agent that drops those parts (react) passed the supports check and trained parts no session ran. They now declare `[llm, skills, agents]` and `[skills, agents, hooks]`, as AHE Adapter does; the CLI agents take every part, so the examples (Codex, Claude Code) are unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Continual Harness and Harness² write skills and sub-agents (Harness² writes hooks too), but neither method declared them in its
evolver.yamlneeds:continual_harnessneeds: [llm]needs: [llm, skills, agents]harness2_upstreamneeds: []needs: [skills, agents, hooks]The Trainer refuses a run whose acting agent does not take what the method needs (
adapter_needs_errors,supportsagainstneeds). Because these parts were not declared, a run withreact(which takes onlycontext,context_toolandtools) passed that check, and trained skills and sub-agents that no session ran. Now such a run is refused before it starts, as AHE Adapter's (needs: [skills, agents, hooks]) already is.The parts come from each method's template exports:
continual-harnessexportsskillsandagents;harness2-codexexportsskills,agentsandhooks.What does not change:
CliAgent.supports = ALL), so every example config of these methods passes the check as before. They all use Codex or Claude Code (examples/officeqa/continual_harness/*.yaml,examples/officeqa/harness2_stream/run_*.yaml).evolver.yamlfiles. The new test is intests/core/test_environment.py, and there is a CHANGELOG line under Fixed.Validation
test_a_method_whose_harness_has_skills_and_roles_is_refused_react, parametrized over AHE Adapter, Continual Harness and Harness². For each method it checks thatreactis refused with the missing parts named and thatcodexis accepted. Run againstorigin/main(the test file copied into a clean worktree), the Continual Harness and Harness² cases fail and AHE Adapter passes. With the change all 3 pass, about 0.1 s each.tests/core/test_environment.py,tests/methods/harness2,tests/methods/continual_harness: 47 passed, 9 skipped, 2 failed. The 2 failures are intest_harness2_on_pi.py::test_what_a_pi_session_spent_is_kept_when_it_times_out_or_is_stopped. They fail the same way onmainlocally, because the upstreamharness2package is not installed in this environment (ModuleNotFoundErrorinchannel.py).python -m pytest --changed --base origin/mainat 8a3a8b7, which selected 1287 of 1942 tests: 1167 passed, 117 skipped, 7 failed. All 7 fail the same way on a cleanmainworktree in this environment, so they come from the local install, not from this change:test_the_moved_modules_old_paths_are_gone×4: an older hermit installed in site-packages still provides the old paths;test_harness2_on_pi×2: the upstreamharness2package is missing;test_rrsi_sees_a_harbor_rollouts_failure_and_a_cli_model_is_refused_for_harbor×1.The follow-up commit changes only CHANGELOG wording. CI is the authority.
Review
needs.needsvalues change. Every value is inADAPTER_NEEDS.needs/supportsrule of the agent layers, applied to two methods that were missing it.Config.loadand the Trainer'sadapter_needs_errorswith each method's realevolver.yaml(find(method).needs), and with the built-inreactandcodexagents.tests/core/beside the existingneedstest and reuses its_confighelper. Its name states the behaviour. It writes only totmp_pathand uses no network or CLI.react, Continual Harness is now refused even whencomponentswrites no skills or sub-agents.reactcould not run this method anyway: the template and the memory handoff need a CLI agent.ahe_adaptercase repeats the existing needs test.🤖 Generated with Claude Code